----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/#review126415 -----------------------------------------------------------
Ship it! Looks good! We'll add some comments to the top of the class and the commit message to mention the current caveats. - Ben Mahler On March 31, 2016, 4:48 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45439/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 4:48 p.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4625 > https://issues.apache.org/jira/browse/MESOS-4625 > > > Repository: mesos > > > Description > ------- > > The current implementation includes some code for generic device > isolation. Once we start isolating more devices, we should abstract > this out and figure out an architecture to support "sub-device" > isolation. > > This was joint work with Rob Todd from Nvidia <[email protected]>. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp > 1e17df1f7d1daf913e0c03e0290dd85b51c2ade0 > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp > c2cdc8fde7a85741be6494ea664d3719d1f13a43 > > Diff: https://reviews.apache.org/r/45439/diff/ > > > Testing > ------- > > Test to come in subsequent patch. > > > Thanks, > > Kevin Klues > >
