> On March 31, 2016, 2:10 a.m., Greg Mann wrote: > > This could break existing clients which include extra whitespace, though it > > does seem that RFC-7230 specifically prohibits whitespace in that location. > > I wonder if a deprecation cycle is advisable for this change? > > > > Also, it's not immediately clear to me: are we using http-parser in > > "strict" mode? > > Vinod Kone wrote: > Good point. Though I would be surprised if typical clients use colons > after header names. IIIUC (zhiwei can correct me if i'm wrong) 2.6.1 > disallowed spaces before colon irrespective of strict mode (which was a bug). > I think they fixed the behavior in 2.6.2 so that it rejects spaces iff the > mode is strict. If that's the case, we should probably just upgrade to 2.6.2 > instead of 2.6.1?
Yes, I think I need to create another ticket to upgrade to 2.6.2. - Zhiwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126160 ----------------------------------------------------------- On March 30, 2016, 1:35 p.m., Zhiwei Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45471/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 1:35 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5063 > https://issues.apache.org/jira/browse/MESOS-5063 > > > Repository: mesos > > > Description > ------- > > Fix a test case bug due to upgrade http-parser to 2.6.1. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 53a0ed03226030104af43a45c6ccfbfc0f4b7e9f > > Diff: https://reviews.apache.org/r/45471/diff/ > > > Testing > ------- > > ../configure --enable-libevent --enable-ssl > > sudo make dist check > > > Thanks, > > Zhiwei Chen > >
