> On March 21, 2016, 5:29 p.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 70 > > <https://reviews.apache.org/r/42860/diff/3/?file=1224521#file1224521line70> > > > > `if (paths.empty()) { ... }` seems like a clearer way to write this.
@neic, @bbannier Thank you for your detail reviews. I rework the patches, could you help review them again? Thanks a lot. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/#review124577 ----------------------------------------------------------- On March 29, 2016, 2:30 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42860/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 2:30 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and > Neil Conway. > > > Bugs: MESOS-4521 > https://issues.apache.org/jira/browse/MESOS-4521 > > > Repository: mesos > > > Description > ------- > > Add paths::overlapping to check whether paths are overlapping. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > ef538045a8b7a1e3d8962c869317d86a85e0259f > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp > 6dff5e76e0e15098c5a262adc50bfcb65f933697 > > Diff: https://reviews.apache.org/r/42860/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
