Only '../configure --with-network-isolator' which unfortunately wasn't the case on neither of the system.. Sorry for the inconvenience, fix is just being tested.
On Mon, Mar 28, 2016 at 7:15 PM, Cong Wang <[email protected]> wrote: > I am wondering how does it pass your test since you did `make check` > on both Linux and OSX? It fails immediately for me on Linux... > > > On Mon, Mar 28, 2016 at 10:09 AM, Joris Van Remoortere > <[email protected]> wrote: > > Joerg will fix these. > > Thanks! > > > > On Mon, Mar 28, 2016 at 7:06 PM, Cong Wang <[email protected]> > wrote: > > > >> This is an automatically generated e-mail. To reply, visit: > >> https://reviews.apache.org/r/45230/ > >> 3rdparty/libprocess/include/process/subprocess.hpp > >> < > https://reviews.apache.org/r/45230/diff/2/?file=1316622#file1316622line311> > (Diff > >> revision 2) > >> > >> public: > >> > >> 301 > >> > >> const Setsid setsid = NO_SETSID, > >> > >> This one breaks build even after all of your 7 patches are committed, > because port_mapping.cpp passes flags but no setsid to subprocess(), this > is not allowed by C++. > >> > >> > >> 3rdparty/libprocess/include/process/subprocess.hpp > >> < > https://reviews.apache.org/r/45230/diff/2/?file=1316622#file1316622line356> > (Diff > >> revision 2) > >> > >> public: > >> > >> 342 > >> > >> const Setsid setsid = NO_SETSID, > >> > >> Ditto > >> > >> > >> - Cong Wang > >> > >> On March 28th, 2016, 4:51 p.m. UTC, Joerg Schad wrote: > >> Review request for mesos and Joris Van Remoortere. > >> By Joerg Schad. > >> > >> *Updated March 28, 2016, 4:51 p.m.* > >> *Bugs: * MESOS-5049 <https://issues.apache.org/jira/browse/MESOS-5049> > >> *Repository: * mesos > >> Description > >> > >> Executing arbitrary setup functions while creating new processes is > >> dangerous as all functions called have to be async safe. As setup > >> functions are used for only very few purposes (setsid, chdir, monitoring > >> and killing a process (see upcoming review) it makes sense to support > >> them safely via parameters to subprocess. Note this review by itself > >> -without the following ones- removing the uses of the old interface will > >> break the build. > >> > >> Testing > >> > >> tested entire chain (see https://reviews.apache.org/r/45236/). > >> > >> Diffs > >> > >> - 3rdparty/libprocess/include/process/ssl/gtest.hpp > >> (2ca705524c8f9bba3c03eef296dc04a353dd236c) > >> - 3rdparty/libprocess/include/process/subprocess.hpp > >> (e0c306aa5cf5f393abb73768bbd287c45730f076) > >> - 3rdparty/libprocess/src/subprocess.cpp > >> (b99bad04f7251169df3bfcec5dee459977440997) > >> > >> View Diff <https://reviews.apache.org/r/45230/diff/> > >> >
