> On March 28, 2016, 3:43 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 554-572 > > <https://reviews.apache.org/r/42516/diff/14/?file=1316581#file1316581line554> > > > > 2 spaces indent, you can take > > https://github.com/apache/mesos/blob/master/src/master/http.cpp#L482 as > > reference. > > > > I think that we still need update `DockerInfo` by adding `network_name` > > and always using `network_name` from `DockerInfo` first; if no > > `network_name` in `DockerInfo`, use `name` from `NetworkInfo` > > Ezra Silvera wrote: > Why? I thought the point was to use NetworkInfo instead of network_name . > Filling the NetworkInfo in case of user-defined network should be mandatory. > > Avinash sridharan wrote: > I agree with Ezra on this. We shouldn't have multiple fields in the > protobuf trying to give the same information. The idea of introducing the > `name` field was to specify the user-defined network. Duplicating this field > in Docker doesn't help. > > Guangya Liu wrote: > You can take a look at @Jie Yu's comments: I think what I am proposing is > that: we add a NetworkInfo.name, and if DOckerInfo.network is not set and > NetworkInfo.name is set, the docker containerizer will do > --net=<NetworkInfo.name>. > > I think that keeping a network name in `DockerInfo` is more suitable for > Docker containerizer.
You can't use DockerInfo.network because it is an enum that always has a value. This is why we added the network_name and everything worked perfectly E2E, we then removed it because you were pointing/asking to use the new NetworkInfo. And if we have that we field why at all we need to check the NetworkInfo for ? Those are both new fields that are going to be filled by the framework. - Ezra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125645 ----------------------------------------------------------- On March 28, 2016, 10:51 a.m., Ezra Silvera wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42516/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 10:51 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-4369 > https://issues.apache.org/jira/browse/MESOS-4369 > > > Repository: mesos > > > Description > ------- > > Signed-off-by: Ezra Silvera <[email protected]> > > > Diffs > ----- > > include/mesos/mesos.proto cb68e2c13409620fa4836c12d877488f4333ace7 > include/mesos/v1/mesos.proto af1dc9e11a26b52cfc348324b8dd796c1f72323f > src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53 > > Diff: https://reviews.apache.org/r/42516/diff/ > > > Testing > ------- > > Using Swarm running on Mesos create a network with "docker network create > --driver=bridge myNetwork" and then create a container on that network: > "docker run --net=myNetwork...." > > > Thanks, > > Ezra Silvera > >
