----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125549 -----------------------------------------------------------
3rdparty/libprocess/include/process/network.hpp (line 75) <https://reviews.apache.org/r/45314/#comment188404> We tried to avoid axecuting too much code between ::connect WSAGetLastError() calls. Constructing the parameter for WindowsSocketError may overwrite the last error. It should be better to pass in the return from WSAGetLastError() as a parameter to the constructor, that is evaluate before the std::string parameter. - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45314/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/network.hpp > 9976257d2d13316062bc95a22ab564ca0df165e5 > 3rdparty/libprocess/src/poll_socket.cpp > 6e6634b4b352e3723096521843546cf56ec6dd8b > > Diff: https://reviews.apache.org/r/45314/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
