> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > new file mode 100644 > > index > > 0000000000000000000000000000000000000000..06528d5a456d6aa8dcee18159392d2ed4e5f3866 > > Binary files /dev/null and > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz differ > > ``` > > Zhiwei Chen wrote: > Yes, I told Vinod in another patch, I think he can solve this issue. > Thanks. > > Vinod Kone wrote: > Looks like you haven't uploaded the tar.gz files? Can you upload them > manually to reviewboard if support/post-reviews.py or rbt doesn't support > binary file uploads? > > haosdent huang wrote: > Hi, @vinodkone As I metioned to zhiwei before, he need apply this patch > to his rbtools if he want upload the binary files. > https://reviews.apache.org/r/40053/diff/3/ is a example that could upload > binary file sucessfully. :-)
Thanks, I thought the Mesos committer may have a better solution for this. - Zhiwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124717 ----------------------------------------------------------- On March 24, 2016, 9:13 a.m., Zhiwei Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44372/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 9:13 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4805 > https://issues.apache.org/jira/browse/MESOS-4805 > > > Repository: mesos > > > Description > ------- > > Upgrade http-parser to 2.6.1 to support PowerPC LE platform. > > > Diffs > ----- > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 6b07aefc58a1daa235b35e83832e47d1878e2e94 > 3rdparty/libprocess/3rdparty/Makefile.am > ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch > f9fac12437a6bedc66353fda1ce9c0d7a383225a > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz > b811b63ce0ad6d71d9d296fed76656c023c76fc5 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/src/decoder.hpp > a20b5ba8fc50d834573d253948645cc863f030dd > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > > Diff: https://reviews.apache.org/r/44372/diff/ > > > Testing > ------- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
