-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45248/
-----------------------------------------------------------
Review request for mesos, Adam B, Ben Mahler, and Joerg Schad.
Bugs: MESOS-4956
https://issues.apache.org/jira/browse/MESOS-4956
Repository: mesos
Description
-------
The `Files` constructor was modified to accept an `Option<string>&
authenticationRealm`, allowing the master or agent to set the authentication
realm during initialization. The master/agent test helpers were modified to
pass the appropriate authentication realm to `Files`, and the GC tests were
modified to authenticate when hitting the 'files/browse' endpoint.
Diffs
-----
src/files/files.hpp 7b65a0a4fbc591fdf22b6f88d6c74034bd8ab599
src/files/files.cpp bcde9d552ac26e2eb702e5d686574f69e640f14d
src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551
src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646
src/tests/cluster.hpp 06424dd741aed2261a926429bb0fc7dea141c11b
src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50
src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
Diff: https://reviews.apache.org/r/45248/diff/
Testing
-------
`sudo make check` was used to test on OSX and CentOS 7.
The master and agent binaries were run both with and without HTTP
authentication, and tested for the expected behavior at the `/files/*`
endpoints.
Thanks,
Greg Mann
