----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124154 -----------------------------------------------------------
Please be careful how you use "should" vs. "must" vs. "may". See http://tools.ietf.org/html/rfc2119 include/mesos/authentication/http/basic_authenticator_factory.hpp (line 40) <https://reviews.apache.org/r/44703/#comment186560> s/should/must/? Which ones are required vs. optional? include/mesos/authentication/http/basic_authenticator_factory.hpp (line 42) <https://reviews.apache.org/r/44703/#comment186561> s/should/must/? include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 56 - 57) <https://reviews.apache.org/r/44703/#comment186562> Why are these quotes escaped, but the others aren't? Because they're inside a string "value"? Seems odd. include/mesos/authentication/http/basic_authenticator_factory.hpp (line 64) <https://reviews.apache.org/r/44703/#comment186563> s/should/must/ or s/should/may/? include/mesos/authentication/http/basic_authenticator_factory.hpp (line 66) <https://reviews.apache.org/r/44703/#comment186564> s/which contains/containing/ s/the authenticator/a new authenticator/ - Adam B On March 17, 2016, 12:40 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44703/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 12:40 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added Doxygen docs for basic HTTP authenticator. > > The structure of the module parameters for the basic HTTP authenticator has > changed, so Doxygen comments were added to the module's header file to > provide an example. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 > > Diff: https://reviews.apache.org/r/44703/diff/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
