> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > <https://reviews.apache.org/r/44755/diff/1/?file=1296713#file1296713line587> > > > > Can you move this function to the top of this file and make it 'static'? > > Anand Mazumdar wrote: > Wondering why does this function needs to be a global and can't be part > of the test fixture i.e. `AppcImageFetcherTest`?
The intend is to use it in all fixtures. Eg, for integegration tests, we have a separate fixture. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review123688 ----------------------------------------------------------- On March 12, 2016, 5:11 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44755/ > ----------------------------------------------------------- > > (Updated March 12, 2016, 5:11 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added helper function to get an Appc image protobuf object with given > parameters. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp > 069af8a0b5e031d9032fd13154cee250f279b404 > > Diff: https://reviews.apache.org/r/44755/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
