> On March 10, 2016, 9:32 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234 > > <https://reviews.apache.org/r/44675/diff/1/?file=1294670#file1294670line234> > > > > (1) Why not just `snapshot`? > > (2) We don't use default capture by reference. Could you explicitly > > list the variables that need to be captured here?
1. Fixed 2. We need to capture all the function parameters, and in this context it equals to capture all. So I don't think it makes sense to list them one by one? - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review122996 ----------------------------------------------------------- On March 10, 2016, 8:19 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44675/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 8:19 p.m.) > > > Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-4740 > https://issues.apache.org/jira/browse/MESOS-4740 > > > Repository: mesos > > > Description > ------- > > Updated `/metrics/snapshot` endpoint to use `jsonify`. > > > Diffs > ----- > > 3rdparty/libprocess/src/metrics/metrics.cpp > f1e6774ebf8670b006ba6ea181439d0ef1529b40 > > Diff: https://reviews.apache.org/r/44675/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Cong Wang > >
