> On March 4, 2016, 6:55 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 61
> > <https://reviews.apache.org/r/44269/diff/5/?file=1281066#file1281066line61>
> >
> > Add a `+` at the end. While not necessary, makes it more readable.
>
> Qian Zhang wrote:
> Agree.
>
> Qian Zhang wrote:
> There will be a compile error if adding a `+` at the end :-(
Probably, you have to add this way:
return Error(
"Failed to find location of the CNI network" +
std::string(" configuration files '") +
flags.network_cni_config_dir.get() + "'");
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44269/#review122123
-----------------------------------------------------------
On March 6, 2016, 4:03 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44269/
> -----------------------------------------------------------
>
> (Updated March 6, 2016, 4:03 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the framework of 'network/cni' isolator.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44269/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
