> On 三月 5, 2016, 9:13 a.m., haosdent huang wrote:
> > I agree this could works completely. But I not sure whether we have a
> > better way to add something like `overlayfs::supported()`? Because some
> > guys may forgor this and continue us `fs::supported("overlayfs")` in the
> > future.
> >
> > Another question is changing the `fs::supported` interface also bring
> > confusing thing. For example, `fs::support("ext3,overlay")` means we check
> > our filesystem support both `ext3` and `overlay`, or check support any one
> > of the list `ext3, overlayfs`?
@haosdent, thanks for the comments. What do you mean by "add something like
`overlayfs::supported()`"? Add a new API? The `fs::supported` was introduced by
`overlayfs` and was only used by overlay fs now.
The current `fs::support("ext3,overlay")` will return `truen` if either `ext3`
or `overlay` is supportted.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/#review122195
-----------------------------------------------------------
On 三月 5, 2016, 8:04 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44421/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2016, 8:04 a.m.)
>
>
> Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.
>
>
> Bugs: MESOS-4874
> https://issues.apache.org/jira/browse/MESOS-4874
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
> support check function, it should check both "overlay" and "overlayfs"
> in "/proc/filesystems".
>
>
> Diffs
> -----
>
> src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0
> src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5
> src/slave/containerizer/mesos/provisioner/backend.cpp
> 55652540e35f9c451ad85cfead575a788aa3eba1
> src/slave/containerizer/mesos/provisioner/backends/overlay.cpp
> 5cc0f8b5a8cd4c945023f874056a8184113186c5
> src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
>
> Diff: https://reviews.apache.org/r/44421/diff/
>
>
> Testing
> -------
>
> root@mesos002:~/src/mesos/m1/mesos/build# uname -r
> 4.2.3-040203-generic
> root@mesos002:~/src/mesos/m1/mesos/build# lsmod | grep over
> overlay 45056 1
> root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
> nodev overlay
> root@mesos002:~/src/
>
> make
> make check
> ./bin/mesos-tests.sh
> --gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
