----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/#review122175 -----------------------------------------------------------
docs/container-image.md (line 11) <https://reviews.apache.org/r/44414/#comment184088> s/containerizers/__containerizers__ docs/container-image.md (lines 44 - 46) <https://reviews.apache.org/r/44414/#comment184090> What about highlight Docker, AppC, OCF here? s/Docker/__Docker__ s/AppC/__AppC__ s/OCF/__OCF__ docs/container-image.md (lines 67 - 77) <https://reviews.apache.org/r/44414/#comment184093> Does it make sense to enable slave add those isolations based on containizer technology? If using `Docker`, then add `docker/runtime` dynamically if the `isolation` flag does not include `docker/runtime`? This can make the configuration simple. docs/container-image.md (line 83) <https://reviews.apache.org/r/44414/#comment184094> default value is `mesos`, do we need to specify it again? docs/container-image.md (lines 124 - 130) <https://reviews.apache.org/r/44414/#comment184095> Does it make sense to guide end user/framework developer refer to https://github.com/apache/mesos/blob/master/src/cli/execute.cpp for an example? I see that there are someone asking this question in dev list, it would be great if we can add the reference code here. docs/container-image.md (line 152) <https://reviews.apache.org/r/44414/#comment184097> s/start the Mesos agent/start the Mesos agent with docker as image provider docs/container-image.md (line 161) <https://reviews.apache.org/r/44414/#comment184098> s/Mesos CLI/Mesos CLI `mesos-execute` docs/container-image.md (lines 263 - 264) <https://reviews.apache.org/r/44414/#comment184100> s/*and* where more recent kernel features such as overlayfs are not available.// The overlay was already supportted. docs/container-image.md (line 283) <https://reviews.apache.org/r/44414/#comment184096> I uploaded a patch here: https://reviews.apache.org/r/44391/ Will rebase this patch as mesos-provisioner.md is now deleted. - Guangya Liu On 三月 5, 2016, 2:20 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44414/ > ----------------------------------------------------------- > > (Updated 三月 5, 2016, 2:20 a.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, Neil Conway, Timothy > Chen, and Vinod Kone. > > > Bugs: MESOS-4873 > https://issues.apache.org/jira/browse/MESOS-4873 > > > Repository: mesos > > > Description > ------- > > Added documentation about container image support. > > > Diffs > ----- > > docs/container-image.md PRE-CREATION > docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 > > Diff: https://reviews.apache.org/r/44414/diff/ > > > Testing > ------- > > Tested the formatting in Mou > > > Thanks, > > Jie Yu > >
