----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122173 -----------------------------------------------------------
BTW, thanks for doing this :) src/tests/persistent_volume_tests.cpp (lines 262 - 263) <https://reviews.apache.org/r/44408/#comment184078> One more small refinement: Now that the master does not use this variable, you should move it above the `MesosSchedulerDriver driver(...);`. Ditto for all modified tests. - Joseph Wu On March 4, 2016, 6:24 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44408/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 6:24 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-4868 > https://issues.apache.org/jira/browse/MESOS-4868 > > > Repository: mesos > > > Description > ------- > > This fix removes the setting up of ACLs in PersistentVolumeTests > as it is no longer needed any more with implicit roles (MESOS-4868). > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 > > Diff: https://reviews.apache.org/r/44408/diff/ > > > Testing > ------- > > make check (in Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
