> On 三月 3, 2016, 7:16 p.m., Jie Yu wrote: > > src/uri/utils.cpp, lines 57-61 > > <https://reviews.apache.org/r/44337/diff/1/?file=1279103#file1279103line57> > > > > OK, this effectively disallowed URI's like: > > ``` > > mailto:[email protected] > > ``` > > > > I think according to URI rfc, 'path' should start with '/' if > > 'authority' (i.e., host) is present. That means the docker URI we create > > using uri::docker::xxx might be an invalid URI according to RFC. > > > > One option is that we callout in uri.proto that 'path' does not include > > the leading '/' if host is specified. But that means for `file:///xxx/yyy`, > > the 'path' part is `xxx/yyy`, rather than `/xxx/yyy`. (same for http). Same > > for `http://xxx/yyy`. > > > > We can still allow users to specify '/xxx/yyy' as the 'path' when > > calling uri::http(..) or uri::file(..), but we need to normalize it and > > remove te leading slash if host is specified.
I was adding some check to see if the `uri.path()` is empty, then do not add the slash. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44337/#review121909 ----------------------------------------------------------- On 三月 3, 2016, 3:03 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44337/ > ----------------------------------------------------------- > > (Updated 三月 3, 2016, 3:03 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4851 > https://issues.apache.org/jira/browse/MESOS-4851 > > > Repository: mesos > > > Description > ------- > > Updated utils for URI constructor streaming. > > > Diffs > ----- > > src/tests/uri_tests.cpp 1d33ab110bed7c0b7ecfa5d608965da5a1729562 > src/uri/utils.cpp 3940dc041c1783eec9e7c950402fd7c42e620d8e > > Diff: https://reviews.apache.org/r/44337/diff/ > > > Testing > ------- > > make > make check > ./bin/mesos-tests.sh --gtest_filter="UriTest.*" > > > Thanks, > > Guangya Liu > >
