----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44326/#review121916 -----------------------------------------------------------
3rdparty/libprocess/src/metrics/metrics.cpp (line 25) <https://reviews.apache.org/r/44326/#comment183771> Not yours, but shouldn't this be #include "process/metrics/metrics.hpp" and preferably be included first? We don't seem to do this consistenly though. 3rdparty/libprocess/src/metrics/metrics.cpp (line 27) <https://reviews.apache.org/r/44326/#comment183772> Already included in the header. 3rdparty/libprocess/src/metrics/metrics.cpp (line 31) <https://reviews.apache.org/r/44326/#comment183773> Not your's, but already included in the header. 3rdparty/libprocess/src/metrics/metrics.cpp (line 33) <https://reviews.apache.org/r/44326/#comment183774> Not yours, but already included in the header. - Benjamin Bannier On March 3, 2016, 3:42 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44326/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 3:42 p.m.) > > > Review request for mesos, Benjamin Bannier and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 7abfadf6d030c52b7e03e773b67c74db6ad5b5df > 3rdparty/libprocess/src/metrics/metrics.cpp > 8812fe213e1005d7b8a7463d1ae2f30f6a80e93d > > Diff: https://reviews.apache.org/r/44326/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
