----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review121661 -----------------------------------------------------------
docs/configuration.md (line 1305) <https://reviews.apache.org/r/44200/#comment183426> Update the documentation based on the comments in `flags.cpp` docs/endpoints/slave/state.json.md (line 91) <https://reviews.apache.org/r/44200/#comment183419> Do we need to change some install scripts to create these paths? I think we should leave the paths as empty. Giving a default path implies that the path should exist during mesos installation. Leaving the path empty would force the operator to specify it while launching `network/cni` isolator. docs/endpoints/slave/state.md (line 91) <https://reviews.apache.org/r/44200/#comment183423> We should leave the directories empty. src/slave/flags.cpp (line 690) <https://reviews.apache.org/r/44200/#comment183421> Maybe s/Directory path/Location ? src/slave/flags.cpp (line 694) <https://reviews.apache.org/r/44200/#comment183422> s/directory/location remove this line: This flag is used for\n" "the `network/cni` isolator.\n", "/tmp/mesos/cni/plugins" src/slave/http.cpp (line 476) <https://reviews.apache.org/r/44200/#comment183424> Should not have default values for the directories. src/slave/http.cpp (lines 476 - 477) <https://reviews.apache.org/r/44200/#comment183425> Should not have default values for the directories. - Avinash sridharan On March 1, 2016, 7:04 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44200/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 7:04 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4761 > https://issues.apache.org/jira/browse/MESOS-4761 > > > Repository: mesos > > > Description > ------- > > Add agent flags for specifying CNI plugin and config directories. > > > Diffs > ----- > > docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 > docs/endpoints/slave/state.json.md a6403eea3426bdec81d170d0829ffe7174862e55 > docs/endpoints/slave/state.md bdd555e0231935c668dea1ba63582348db2b3629 > src/slave/flags.hpp c07932157ffe36ea36f1def4c7d92b79d2219c48 > src/slave/flags.cpp 7f139e99e8392fe95bb30070896ed9d95dfe5701 > src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e > > Diff: https://reviews.apache.org/r/44200/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
