----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121001 -----------------------------------------------------------
As with the previous one, I don't know whether this metric will help anyone. So can you add a use case in the JIRA? src/tests/hierarchical_allocator_tests.cpp (lines 2432 - 2436) <https://reviews.apache.org/r/43881/#comment182578> This looks rather hard to read. I think a better solution would look like this: ```c++ std::string metricKey = strings::join("/", "allocator/framework_allocations", framework.id()); EXPECT_EQ(1, metrics.values[metricKey]); ``` src/tests/hierarchical_allocator_tests.cpp (lines 2471 - 2480) <https://reviews.apache.org/r/43881/#comment182600> Same as above. - Alexander Rojas On Feb. 26, 2016, 6:02 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43881/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 6:02 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4719 > https://issues.apache.org/jira/browse/MESOS-4719 > > > Repository: mesos > > > Description > ------- > > Added allocator metric for the number of allocations to a framework. > > > Diffs > ----- > > docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43881/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
