----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/#review120300 -----------------------------------------------------------
src/master/master.hpp (line 545) <https://reviews.apache.org/r/43868/#comment181728> `getFlags() const` src/tests/master_tests.cpp (line 975) <https://reviews.apache.org/r/43868/#comment181729> add blank line. src/tests/master_tests.cpp (line 983) <https://reviews.apache.org/r/43868/#comment181730> Is this necessary? If so, please clear it up. Can you also show which part of code will use this function? - Klaus Ma On Feb. 23, 2016, 1:23 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43868/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2016, 1:23 p.m.) > > > Review request for mesos, Guangya Liu, Joris Van Remoortere, and Qian Zhang. > > > Bugs: MESOS-3481 > https://issues.apache.org/jira/browse/MESOS-3481 > > > Repository: mesos > > > Description > ------- > > MESOS-3481 Add const accessor to Master flags. > > > Diffs > ----- > > src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d > src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf > > Diff: https://reviews.apache.org/r/43868/diff/ > > > Testing > ------- > > Added one new unit test MasterTest::Flags > > `make check` passed > > > Thanks, > > Jay Guo > >
