----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/ -----------------------------------------------------------
(Updated Feb. 19, 2016, 7:38 p.m.) Review request for mesos, Greg Mann and Joris Van Remoortere. Changes ------- Rebase. Repository: mesos Description ------- For consistency, we should do `driver.stop(); driver.join();` if a `MesosSchedulerDriver` has been started by the unit test. The destructor for `MesosSchedulerDriver` will do something _similar_, so the consequence of omitting these calls is not dire, but it seems safer to be consistent between all the test cases. Diffs (updated) ----- src/tests/executor_http_api_tests.cpp 36a042ed103271ca873450236f39a8152fbbf07e src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 src/tests/reservation_endpoints_tests.cpp afe81b1d38a1b3a82583720f26482ddcde8f5e85 src/tests/scheduler_event_call_tests.cpp bd8920fa9d5475e5f6533c8424ebff1588bfe645 src/tests/scheduler_http_api_tests.cpp 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a Diff: https://reviews.apache.org/r/42877/diff/ Testing ------- make check Note that adding the `driver.stop(); driver.join();` calls to two of the slave tests requires adding an extra shutdown expectation to avoid a GMock warning. Thanks, Neil Conway
