> On Feb. 19, 2016, 3:16 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 205 > > <https://reviews.apache.org/r/43613/diff/3/?file=1253037#file1253037line205> > > > > Slightly unclear which is which. Attempt to clarify: > > > > ... Once this method has been called, its receiver will no longer > > perform cleanup in its destructor. > > > > Vernacular alternative: > > > > ... When this method is called, this wrapper instance will no longer > > perform cleanup during its destruction.
I reworded and added a tidbit about *not* destroying containers when these two methods are called. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review119858 ----------------------------------------------------------- On Feb. 19, 2016, 11:25 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43613/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 11:25 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem > Harutyunyan. > > > Bugs: MESOS-4633 and MESOS-4634 > https://issues.apache.org/jira/browse/MESOS-4633 > https://issues.apache.org/jira/browse/MESOS-4634 > > > Repository: mesos > > > Description > ------- > > Major rewrite of the `tests/cluster` helpers. This strongly ties the scope > of test objects to the test body. > > Changes the `Cluster` class into two RAII objects (`Master` and `Slave`). > The `Slave` object performs cleanup originally found in > `cluster::Slave::stop`. `cluster::Master::start` and `cluster::Slave::start` > were changed to factory methods. > > > Diffs > ----- > > src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 > src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 > > Diff: https://reviews.apache.org/r/43613/diff/ > > > Testing > ------- > > Tests are run at the end of this review chain. > > > Thanks, > > Joseph Wu > >
