----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/#review119754 -----------------------------------------------------------
Patch looks great! Reviews applied: [43260, 43261, 43271, 43272] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 18, 2016, 7:22 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43272/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 7:22 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till > Toenshoff. > > > Bugs: MESOS-4609 > https://issues.apache.org/jira/browse/MESOS-4609 > > > Repository: mesos > > > Description > ------- > > Delegates some of the environment logic in the containerizer and fetcher to > the `subprocess_environment` helper. > Changes the logrotate container logger to use the default `environment` for > `subprocess`. > > > Diffs > ----- > > src/slave/container_loggers/lib_logrotate.cpp > cf5f238eb3b6217b848cf23f8c9cd1848bf9a9f0 > src/slave/containerizer/containerizer.cpp > 59904684cdeb17ef2b42092a3558802c42bfb6bd > src/slave/containerizer/fetcher.cpp > 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 > > Diff: https://reviews.apache.org/r/43272/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Joseph Wu > >
