----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review119738 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (line 785) <https://reviews.apache.org/r/33174/#comment181086> Do you need to call update for this case (command task but agent is not running in a docker container)? src/slave/containerizer/docker.cpp (lines 811 - 815) <https://reviews.apache.org/r/33174/#comment181077> This is done after the container has been launched. We should definitely call out the fact that there's a short window after the container has been launched before the container's cfs quota is updated. During that window, it's not subject to cfs throttling. Alternatively, we could set `--cpu-period` and `--cpu-quota` during launch so that we don't have to worry about that window. src/slave/containerizer/docker.cpp (line 812) <https://reviews.apache.org/r/33174/#comment181078> Ditto on using 'update()' here. src/slave/containerizer/docker.cpp (lines 1131 - 1133) <https://reviews.apache.org/r/33174/#comment181079> Nits on style: ``` write = cgroups::cpu::cfs_period_us( cpuHierarchy.get(), cpuCgroup.get(), CPU_CFS_PERIOD); ``` src/slave/containerizer/docker.cpp (lines 1142 - 1144) <https://reviews.apache.org/r/33174/#comment181080> Ditto on style: ``` write = cgroups::cpu::cfs_quota_us( cpuHierarchy.get(), cpuCgroup.get(), quota); ``` - Jie Yu On Dec. 15, 2015, 8:14 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33174/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 8:14 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2617 > https://issues.apache.org/jira/browse/MESOS-2617 > > > Repository: mesos > > > Description > ------- > > Fix for docker containerizer not configuring CFS quotas correctly. > > It would be nice to refactor all this isolation code in a way that can be > shared between all containerizers, as this is basically just copied from the > CgroupsCpushareIsolator, but that's a much bigger undertaking. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e > > Diff: https://reviews.apache.org/r/33174/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
