----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review119209 -----------------------------------------------------------
Just some flyby comments. src/slave/containerizer/docker.cpp (line 1119) <https://reviews.apache.org/r/43569/#comment180481> You don't need to use `stringify` here. `ContainerId` has the ostream operator. src/slave/containerizer/mesos/containerizer.cpp (line 1185) <https://reviews.apache.org/r/43569/#comment180483> If we are adding `ContainerId` to other messages, we should add it here as well? src/slave/containerizer/mesos/containerizer.cpp (line 1588) <https://reviews.apache.org/r/43569/#comment180484> Maybe s/Ignore destroy of/Cannot reap/ ? - Avinash sridharan On Feb. 15, 2016, 1:56 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43569/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2016, 1:56 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Updated log message if container not found. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc > src/slave/containerizer/mesos/containerizer.cpp > 3de214d6c71773f5deb5db9fe3f527dd5064737f > > Diff: https://reviews.apache.org/r/43569/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
