----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/#review118865 -----------------------------------------------------------
src/common/resources.cpp (lines 202 - 205) <https://reviews.apache.org/r/42992/#comment180178> Does this require that the num_consumers should be same? src/common/resources.cpp (lines 335 - 338) <https://reviews.apache.org/r/42992/#comment180194> does this require the num_consumers be same when subtract? src/common/resources.cpp (line 729) <https://reviews.apache.org/r/42992/#comment180176> add a period to the end. src/common/resources.cpp (line 734) <https://reviews.apache.org/r/42992/#comment180177> s/Resource type/Resoure `Resource type` is usally specifying if the resources is `SCALAR`, `SET` or `RANGES`. src/common/resources.cpp (lines 1653 - 1656) <https://reviews.apache.org/r/42992/#comment180183> Can you please add some comments to clarify the difference between `None` and `0` for `num_consumers`? - Guangya Liu On 二月 5, 2016, 10:57 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42992/ > ----------------------------------------------------------- > > (Updated 二月 5, 2016, 10:57 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > Added new Offer::Operation of SHARE and UNSHARE for resources. > Added ShareInfo within Resources protobuf to allow for sharing of resources > and keep track of consumers of such resources. > Shareable resources keeps track of its consumers and makes decision based on > that during task launch and task termination. > Allow DESTROY or UNSHARE for shared volumes only if reference count is 0. > > > Diffs > ----- > > include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 > include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1 > include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 > include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af > src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 > src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2 > src/master/allocator/mesos/hierarchical.cpp > a9d2c23162892e22220f97d89a076d2311091d91 > src/master/allocator/sorter/drf/sorter.cpp > 18797e42a9c2bd20392020237cfae600a5ffe12c > src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 > src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 > src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c > src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca > src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 > > Diff: https://reviews.apache.org/r/42992/diff/ > > > Testing > ------- > > make check done. > > > Thanks, > > Anindya Sinha > >
