> On Feb. 9, 2016, 10:23 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3186-3199 > > <https://reviews.apache.org/r/43258/diff/5/?file=1238750#file1238750line3186> > > > > I think we should only do this if 'future' is Ready. Otherwise, we > > cannot tell if we should fill IP or not because a network isolator might be > > used and it advertised a different IP.
Agreed. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118478 ----------------------------------------------------------- On Feb. 9, 2016, 11:47 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43258/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 11:47 p.m.) > > > Review request for mesos, Jie Yu and Kapil Arya. > > > Bugs: MESOS-4490 > https://issues.apache.org/jira/browse/MESOS-4490 > > > Repository: mesos > > > Description > ------- > > Modified agent to get container status from containerizer. > > > Diffs > ----- > > src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 > src/slave/slave.cpp 9dda3a2c4dc4c355488d34dc8d0606330a756f2a > src/tests/master_tests.cpp 0357b1c259472213181a65e5adbe6d5caa1698ad > src/tests/reconciliation_tests.cpp 1cbc3230d003a84277b91da6470828ebf73ef897 > src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 > src/tests/status_update_manager_tests.cpp > 7bedd499a241a61938069381e0d4fafa4b8f96db > > Diff: https://reviews.apache.org/r/43258/diff/ > > > Testing > ------- > > make and make check > > > Also ran sudo tests . All tests passed except for these root tests: > DockerContainerizerTest.ROOT_DOCKER_Launch_Executor (this is failing on the > master as well, and seems flaky ?) > CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Listen (Since swap was > enabled on the system) > CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreaseRSS (Since swap was > enabled on the system) > > > Thanks, > > Avinash sridharan > >
