-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43269/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610
Repository: mesos
Description
-------
MasterContender/MasterDetector loadable as modules.
There is a large set of changes here, mostly due to a namespace rename. The
previous version had the MasterContender/Detector APIs under an internal
namespace, which didn't seem appropriate for an external contract. So the
actual code changes that were impactful are relatively surgical, with then a
wide ranging downstream cleanup to make the existing code base reference the
new location.
Diffs
-----
include/mesos/master/contender.hpp PRE-CREATION
include/mesos/master/detector.hpp PRE-CREATION
include/mesos/module/contender.hpp PRE-CREATION
include/mesos/module/detector.hpp PRE-CREATION
include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
src/Makefile.am 22f51319a1c06da02cac5822d42315e3027cf500
src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d
src/examples/test_contender_module.cpp PRE-CREATION
src/examples/test_detector_module.cpp PRE-CREATION
src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847
src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735
src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723
src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e
src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58
src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22
src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9
src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171
src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75
src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889
src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712
src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85
src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625
src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c
src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1
src/tests/master_authorization_tests.cpp
29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/master_contender_detector_tests.cpp
6375586c31b1fd406529bf299dad6e321b945de8
src/tests/master_slave_reconciliation_tests.cpp
d41178eb41df519073fc0890c5716bbc9fed6ad2
src/tests/master_tests.cpp 0357b1c259472213181a65e5adbe6d5caa1698ad
src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8
src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
src/tests/oversubscription_tests.cpp c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb
src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5
src/tests/persistent_volume_tests.cpp
cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
src/tests/reconciliation_tests.cpp 1cbc3230d003a84277b91da6470828ebf73ef897
src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7
src/tests/scheduler_event_call_tests.cpp
bd8920fa9d5475e5f6533c8424ebff1588bfe645
src/tests/scheduler_http_api_tests.cpp
9eb1de7d9541395b92b951f0fe0ddbb2f219fe30
src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77
src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77
Diff: https://reviews.apache.org/r/43269/diff/
Testing
-------
In addition to all unit tests passing, we are currently using this
functionality in our environment with a custom consensus stack. In our world,
we have a C++ plugin that calls out to an HTTP REST service (implemented in
Java/Scala, not that it matters).
Thanks,
Mark Cavage
