> On Feb. 5, 2016, 12:31 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 200 > > <https://reviews.apache.org/r/42618/diff/7/?file=1231964#file1231964line200> > > > > What's defaultPrimary? Who is the user? Can you just do the following: > > > > ``` > > if (!primaries.empty()) { > > handleManager = NetClsHandleManager(primaries.get()); > > } > > ```
Have converted defaultPrimary as a helper function in `CgroupsNetClsIsolatorProcess` . Since the defaultPrimary is a concept specific to the isolator, and it needs to store the ranges, on which the defaultPrimary operates, as well. Hence, have introduced an `IntervalSet<uint16_t>` field in `CgroupsNetClsIsolatorProcess` as well. > On Feb. 5, 2016, 12:31 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 408 > > <https://reviews.apache.org/r/42618/diff/7/?file=1231964#file1231964line408> > > > > Can you make 'defaultPrimiary' a helper method instead of a field > > member. The field member will go away in the future once we introduce other > > allocation policies like one primary per framweork. Please see my comments above about introducing an IntervalSet<uint16_t> field in `CgroupsNetClsIsolatorProcess`. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117916 ----------------------------------------------------------- On Feb. 5, 2016, 3:31 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42618/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 3:31 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > 85004aea4c1ee4b25e106f3ce40025c69f1ce030 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > bf6c88341dedc0a37546c04f38197c892b498684 > > Diff: https://reviews.apache.org/r/42618/diff/ > > > Testing > ------- > > make and make check > > > Thanks, > > Avinash sridharan > >
