----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/#review118069 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 171 - 173) <https://reviews.apache.org/r/42588/#comment179330> Why error here? THis should be false, right? I'll fix it for you. - Jie Yu On Feb. 5, 2016, 2:16 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42588/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 2:16 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > Added unit-test for `NetClsHandleManager`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > 85004aea4c1ee4b25e106f3ce40025c69f1ce030 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > bf6c88341dedc0a37546c04f38197c892b498684 > src/tests/containerizer/isolator_tests.cpp > 67322abc776cbd501385932676852a79b74ef248 > > Diff: https://reviews.apache.org/r/42588/diff/ > > > Testing > ------- > > make and make check. > > > Thanks, > > Avinash sridharan > >
