----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/#review117882 -----------------------------------------------------------
3rdparty/libprocess/src/help.cpp (line 107) <https://reviews.apache.org/r/42957/#comment179137> How could the 2nd part of the condition arise? -- below you perform pruning of empty branches. I think either the 2nd part is redundant, or you should perform pruning before returning `false`. 3rdparty/libprocess/src/help.cpp (lines 123 - 129) <https://reviews.apache.org/r/42957/#comment179134> Is this equivalent to just `return helps.erase(id)`? - Benjamin Bannier On Feb. 4, 2016, 9:30 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42957/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 9:30 p.m.) > > > Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. > > > Bugs: MESOS-4552 > https://issues.apache.org/jira/browse/MESOS-4552 > > > Repository: mesos > > > Description > ------- > > Previously, there was no way to remove an installed help > string for a given endpoint. > > This commit adds the ability to remove these help strings. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/help.hpp > 2e76a6a5b1069abce879374a88cea65036873f1d > 3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae > > Diff: https://reviews.apache.org/r/42957/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
