> On Feb. 4, 2016, 1:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2202 > > <https://reviews.apache.org/r/43144/diff/1/?file=1231709#file1231709line2202> > > > > blank line before.
Fixed. Updated patch. > On Feb. 4, 2016, 1:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2211 > > <https://reviews.apache.org/r/43144/diff/1/?file=1231709#file1231709line2211> > > > > Just `os::getenv("LIB...")` is OK. The string is used in two places: getenv and VLOG(WARNING). I thought to avoid mismatch between the two literals. How about constexpr auto env_var = "LIBPROCESS_MAX_WORKER_THREADS"; ? - Maged ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117806 ----------------------------------------------------------- On Feb. 4, 2016, 7:25 p.m., Maged Michael wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43144/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 7:25 p.m.) > > > Review request for mesos and Klaus Ma. > > > Repository: mesos > > > Description > ------- > > Added env var to set upper bound on number of libprocess worker threads. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp d8a74d7 > > Diff: https://reviews.apache.org/r/43144/diff/ > > > Testing > ------- > > Passed make check on x86_64 Ubuntu 14.04. > > Invocations of mesos-master, mesos-slave, and mesos-tests with the > LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", > "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as > expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. > The last 3 tests generated warnings. > > > Thanks, > > Maged Michael > >
