----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42539/#review116882 -----------------------------------------------------------
src/launcher/executor.cpp (line 269) <https://reviews.apache.org/r/42539/#comment177978> I could understand we need TaskCommand to combine different things. But because the interface is `void launchTask(ExecutorDriver* driver, const TaskInfo& task)`. Ignore it and use the command line param to launchTaks looks a bit strange. Maybe we change to `void launchTask(ExecutorDriver* driver, const TaskCommand& task)` - haosdent huang On Jan. 28, 2016, 8:28 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42539/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 8:28 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-4004 > https://issues.apache.org/jira/browse/MESOS-4004 > > > Repository: mesos > > > Description > ------- > > Support image specified Entrypoint and Cmd. > > > Diffs > ----- > > src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 > src/slave/containerizer/mesos/containerizer.hpp > 811ab7937279c4a55da450c136f9fcb1303ea0d5 > src/slave/containerizer/mesos/containerizer.cpp > 4b504dbb58823ce7675f1d2048dcc7a27c05663d > > Diff: https://reviews.apache.org/r/42539/diff/ > > > Testing > ------- > > make check(ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
