----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42878/#review116677 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/isolator_tests.cpp (lines 866 - 867) <https://reviews.apache.org/r/42878/#comment177760> Can you move this down right above `cgroups::processes`? src/tests/containerizer/isolator_tests.cpp (line 928) <https://reviews.apache.org/r/42878/#comment177761> Sorry, I missed that during review. Why snake_case here? - Jie Yu On Jan. 27, 2016, 11:16 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42878/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 11:16 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4530 > https://issues.apache.org/jira/browse/MESOS-4530 > > > Repository: mesos > > > Description > ------- > > Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy. The > test relied on the flags.cgroups_hierarchy to learn the net_cls hierarchy, > instead it should be making a call to cgroups::hierarchy to learn the > hierarchy. > > > Diffs > ----- > > src/tests/containerizer/isolator_tests.cpp > 7033ac1aa7ae8a3cf06d4f717580ce5a5afb648a > > Diff: https://reviews.apache.org/r/42878/diff/ > > > Testing > ------- > > make and make check on Debian 8 > > Also ran the patch on CentOS 6 with Greg's help. He was using > (boxcutter/centos66) vagrant image to test this patch. (boxcutter/centos66) > is where this test was failing. > > > Thanks, > > Avinash sridharan > >
