-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42880/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Bugs: MESOS-4535
https://issues.apache.org/jira/browse/MESOS-4535
Repository: mesos
Description
-------
Adds a test which checks for erroneous calls to `os::close` by the
LogrotateContainerLogger. This may happen by accident if the container logger
module uses `Subprocess::PIPE` when launching child processes; as libprocess
will track these FDs and close them (possibly even if they've already been
closed) when the child processes exit.
Diffs
-----
src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491
Diff: https://reviews.apache.org/r/42880/diff/
Testing
-------
make check
Test failed (expected) when I reverted the previous patch and ran `make check`
Thanks,
Joseph Wu
