----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42361/#review115714 -----------------------------------------------------------
src/tests/reservation_tests.cpp (line 1818) <https://reviews.apache.org/r/42361/#comment176747> `s/invalidated/invalid.` - Michael Park On Jan. 20, 2016, 7:04 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42361/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 7:04 p.m.) > > > Review request for mesos, Jie Yu, Michael Park, and Vinod Kone. > > > Bugs: MESOS-4195 > https://issues.apache.org/jira/browse/MESOS-4195 > > > Repository: mesos > > > Description > ------- > > Added dynamic reservation test with no authentication. > > Currently, we do not allow dynamic reservations without a principal. The > `ReservationInfo.principal` field is currently being migrated to `optional`, > and in 0.28.0 we plan to begin allowing dynamic reservations without a > principal. This test was added to verify that currently, framework reserve > operations without a principal will fail as expected. > > > Diffs > ----- > > src/tests/reservation_tests.cpp 2ea3b6e48e75f438b325211fb562db19bd3a82e0 > > Diff: https://reviews.apache.org/r/42361/diff/ > > > Testing > ------- > > A new test, `ReservationTest.ReservationInfoNoAuthentication`, was added, and > `make check` was used to test. The new test was also run with > `--gtest_repeat=1000 --gtest_break_on_failure=1`. > > > Thanks, > > Greg Mann > >
