----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review115294 -----------------------------------------------------------
Can you talk to Guangya and merge this patch with https://reviews.apache.org/r/42123/ ? Logically, they're touching the same things. src/slave/slave.cpp (line 4632) <https://reviews.apache.org/r/40379/#comment176257> It would be better to filter than to substract. i.e. oversubscribed = oversubscribed.usageSlack(); src/slave/slave.cpp (lines 4637 - 4638) <https://reviews.apache.org/r/40379/#comment176258> After the above change (and some changes to the helpers I suggested in earlier reviews), you can do: ``` oversubscribed += oversubscribable; Resource::RevocableInfo revocableInfo; revocableInfo.set_type(Resource::RevocableInfo::USAGE_SLACK); oversubscribed = oversubscribed.flatten(revocableInfo); ``` - Joseph Wu On Jan. 7, 2016, 4:04 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40379/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 4:04 a.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris > Van Remoortere, Joseph Wu, and Jian Qiu. > > > Bugs: MESOS-3930 > https://issues.apache.org/jira/browse/MESOS-3930 > > > Repository: mesos > > > Description > ------- > > In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK > for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps > to update `RevocableInfo::type` for Oversubscription. > > > Diffs > ----- > > include/mesos/slave/resource_estimator.hpp 27612ca > src/slave/slave.cpp 9d80c96 > > Diff: https://reviews.apache.org/r/40379/diff/ > > > Testing > ------- > > make (make check is on-going) > > > Thanks, > > Klaus Ma > >
