> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > Thanks Alex! I ended up going over the structure of the recover code and > > left some higher level comments. There also appears to be a bug that will > > crash the master that I marked as an issue :) > > > > Have we convinced ourselves that we want to act on partial state when quota > > is *not* set? It seems to complicate things here, and acting on partial > > state w/o quota has some issues as well?
Thanks a bunch for a thorough review, Ben! I have opened a separate ticket to track the bug and other comments you had left: https://issues.apache.org/jira/browse/MESOS-4417. > On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 205-206 > > <https://reviews.apache.org/r/42222/diff/1/?file=1195000#file1195000line205> > > > > It looks like if we trip the `resume` call in `addSlave`, this delayed > > resume will crash the master due to the `CHECK(paused)` that currently > > resides in `resume`. > > > > Something I'm missing? > > Joris Van Remoortere wrote: > Thanks for your review Ben! > I'm committing just the comment change for this patch. > I'll leave this issue open as we want to address it in a separate patch. Filed: https://issues.apache.org/jira/browse/MESOS-4417 - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42222/#review114628 ----------------------------------------------------------- On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42222/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 11:06 p.m.) > > > Review request for mesos, Ben Mahler and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > > Diff: https://reviews.apache.org/r/42222/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
