----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42370/#review114803 -----------------------------------------------------------
Ship it! src/tests/hdfs_tests.cpp (line 117) <https://reviews.apache.org/r/42370/#comment175656> 2 lines apart please. - Jie Yu On Jan. 15, 2016, 11:56 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42370/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 11:56 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The HDFS du command can output 3 fields in later Hadoop versions. > We should accept both 2-field and 3-field versions for better > compatibility. > > > Diffs > ----- > > src/hdfs/hdfs.cpp 51f016b049c6e947c4d27fbbbf79c53f9ec5a51e > src/tests/hdfs_tests.cpp 29f156028af57b83ee2aa299f3b1c89e96d15fd0 > > Diff: https://reviews.apache.org/r/42370/diff/ > > > Testing > ------- > > make check on Centos6 w/ devtoolset-3. Running in production for a number of > weeks. > > > Thanks, > > James Peach > >
