> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/slave/slave.cpp, line 1370 > > <https://reviews.apache.org/r/41305/diff/1/?file=1161529#file1161529line1370> > > > > Before trying to get task's executor via `task.executor()`, suggest to > > add a CHECK to ensure the task always has an executor.
It's not necessary, executor is set in master. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review110166 ----------------------------------------------------------- On Jan. 15, 2016, 1:17 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41305/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 1:17 p.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian > Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-1718 > https://issues.apache.org/jira/browse/MESOS-1718 > > > Repository: mesos > > > Description > ------- > > MESOS-1718: move getExecutorInfo from slave to master > > > Diffs > ----- > > src/master/constants.hpp ebab341e58035d4b579828add752c1ee37efeb95 > src/master/master.hpp f02d165874fa8023675e545793de699aeecae29b > src/master/master.cpp 863a11c82d322f56db1ccf25b73a4ffff1304a46 > src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a > > Diff: https://reviews.apache.org/r/41305/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
