> On Jan. 12, 2016, 1:24 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 336 > > <https://reviews.apache.org/r/42167/diff/1/?file=1192483#file1192483line336> > > > > s/for recursive/for the recursive/ > > s/sequencially/sequentially/
We ended up re-phrasing this one, thanks! > On Jan. 12, 2016, 1:24 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 339-346 > > <https://reviews.apache.org/r/42167/diff/1/?file=1192483#file1192483line339> > > > > Wouldn't it be simpler to do this? > > `return parse(reflection->AddMessage(message, field), object);` > > > > The return types are the same. > > > > Ditto for the `else`. Thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42167/#review113894 ----------------------------------------------------------- On Jan. 11, 2016, 11:39 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42167/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 11:39 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van > Remoortere, Joseph Wu, and Timothy Chen. > > > Bugs: MESOS-4311 > https://issues.apache.org/jira/browse/MESOS-4311 > > > Repository: mesos > > > Description > ------- > > Fixed stout protobuf::parse passing error message in nested JSON. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 > > Diff: https://reviews.apache.org/r/42167/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
