> On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 306-310 > > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line306> > > > > 1) what about adding "update Quota" here and remove it from L189 > > 2) no Quota Limit but only guarantee > > > > Another point is that shall we put quota design document link here to > > naviagte someone there if they want to get some design detail for Quota? > > Joerg Schad wrote: > 1) Added it here (brief) with a link to L189. > 2) As we do not mention Quota Limits above, I would also not mention it > here (see our current definition of quota).
OK > On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, line 175 > > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line175> > > > > Do we need to mention that the 80% is not configurable now? > > Joerg Schad wrote: > I would just add a note once it is configurable. OK > On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, line 70 > > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line70> > > > > s/to even/even ? > > Joerg Schad wrote: > changed it to 'event to ignore' I think you meant "even to ignore". > On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 33-34 > > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line33> > > > > But we did have plan to introduce maximal limit in MESOS-3858 , can we > > calarify here? > > Joerg Schad wrote: > We discussed that part, but agreed that this documentation is for > operators (how to use the current feature) and supposed to reflect the > current state. Fair enough. > On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, line 20 > > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line20> > > > > s/a cluster-wide dynamic reservation/a cluster-wide dynamic reservation > > without resource preemption > > > > MESOS-1607 is introducing oversubscription for reservations, so the > > reservation resources can be preempted based on workload. Can we clarify it > > a bit here as above? > > Joerg Schad wrote: > IMO 'without resource preemption' is adding more confusion than details > at this point . Can you maybe explain the motivation behing adding this here? > > With Mesos-1607 I would not reference open Jiras in the operator guide > which is concerned with how to use the current feature. OK, I see, just want to clarify that Quota do not support resource preemption now, as dynamic reservation is going to support resource preemption in MESOS-1607, "Quota can be viewed as a cluster-wide dynamic reservation" makes me think that the Quota also supports resource preemption like dynamic reservations. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113601 ----------------------------------------------------------- On 一月 8, 2016, 10:26 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42040/ > ----------------------------------------------------------- > > (Updated 一月 8, 2016, 10:26 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van > Remoortere, and Neil Conway. > > > Bugs: MESOS-3877 > https://issues.apache.org/jira/browse/MESOS-3877 > > > Repository: mesos > > > Description > ------- > > Added Quota Operator Documentation. > > > Diffs > ----- > > docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 > docs/quota.md PRE-CREATION > > Diff: https://reviews.apache.org/r/42040/diff/ > > > Testing > ------- > > Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56 > > > Thanks, > > Joerg Schad > >
