----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/#review112512 -----------------------------------------------------------
src/slave/slave.hpp (lines 392 - 400) <https://reviews.apache.org/r/41856/#comment172981> Can you please explain why not adding some global counters for totalAllocationSlack, pendingAllocationSlac, occupiedAllocationSlack etc? src/slave/slave.hpp (line 399) <https://reviews.apache.org/r/41856/#comment172978> It is better add some comments for those helper functions especially for eviciting allocation slack which is used to calculate some potential allocation slack resources. src/slave/slave.hpp (line 588) <https://reviews.apache.org/r/41856/#comment172979> It is better add more comments to explain this kind of executors. src/slave/slave.cpp (line 3937) <https://reviews.apache.org/r/41856/#comment172982> Why account the queued task here? Does not this handled by framework->penging and framework->pendingExecutors? - Guangya Liu On Jan. 4, 2016, 5:29 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41856/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 5:29 a.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-3892 > https://issues.apache.org/jira/browse/MESOS-3892 > > > Repository: mesos > > > Description > ------- > > helper functions to get allocation slack > > > Diffs > ----- > > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c > > Diff: https://reviews.apache.org/r/41856/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
