----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112340 -----------------------------------------------------------
src/executor/executor.cpp (line 229) <https://reviews.apache.org/r/41283/#comment172812> We should probably limit the max value here. src/executor/executor.cpp (line 244) <https://reviews.apache.org/r/41283/#comment172810> Whats the maximum value allowed here? Might be a good idea to have it bounded. Also what is the unit of time here? src/executor/executor.cpp (line 291) <https://reviews.apache.org/r/41283/#comment172815> Have we considered using ```override``` keyword here? src/executor/executor.cpp (line 370) <https://reviews.apache.org/r/41283/#comment172814> Have we considered using ```%``` operator to achieve the same semantics? Couple of reasons: - Expresses the semantics in simple manner. - Efficient in terms if number of instructions (1 DIV operation vs a DIV + MUL) - Jojy Varghese On Dec. 30, 2015, 1:30 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41283/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, 1:30 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3550 > https://issues.apache.org/jira/browse/MESOS-3550 > > > Repository: mesos > > > Description > ------- > > This change introduces the implementation for the executor library. > > This uses the new HTTP Connection interface to ensure calls are properly > pipelined. > > `connected` -> Callback invoked when a TCP connection is established with the > agent. > `disconnected` -> When the TCP connection is interrupted possibly due to an > agent restart. > `received` -> When the executor receives events from the agent upon > subscribing. > > > Diffs > ----- > > src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e > src/executor/executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41283/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
