----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41751/#review112069 -----------------------------------------------------------
Ship it! LGTM, just some minor nits and cleanups. 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 169) <https://reviews.apache.org/r/41751/#comment172378> Nit: `const` 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 170) <https://reviews.apache.org/r/41751/#comment172379> Nit: `const` 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 174) <https://reviews.apache.org/r/41751/#comment172380> Can we remove the `else` here i.e. one level of nesting: i.e. ``` if (_basename == "." || _basename == ".." || index == std::string::npos) { return None(); } return _basename.substr(index); ``` - Anand Mazumdar On Dec. 28, 2015, 10:09 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41751/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 10:09 p.m.) > > > Review request for mesos, Anand Mazumdar and Artem Harutyunyan. > > > Repository: mesos > > > Description > ------- > > This was based on boost's extension method: > http://www.boost.org/doc/libs/1_59_0/libs/filesystem/doc/reference.html#path-extension > > Cleanups to libprocess and mesos follow. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > 0b986f0898da95c4cffd8bde1adfd9994d567096 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp > 821dbb185f09e2f279d95fd354ce2168cddf1bac > > Diff: https://reviews.apache.org/r/41751/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Ben Mahler > >
