> On Dec. 21, 2015, 11:38 p.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, lines 57-60 > > <https://reviews.apache.org/r/41603/diff/2/?file=1173823#file1173823line57> > > > > Not yours but it would be greate to update it as following: > > > > using mesos::quota::QuotaInfo; > > > > using process::Future; > > using process::Owned;
I grepped the codebase and found out that we indeed order `using` groups alphabetically. The only exception (and we are unfortunately inconsistent about it) is STL `using`s: sometimes we put them first (like with STL includes), sometimes alphabetically (after `process::*`). I'll reorder the whole using section. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41603/#review111555 ----------------------------------------------------------- On Dec. 22, 2015, 11:01 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41603/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 11:01 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3960 > https://issues.apache.org/jira/browse/MESOS-3960 > > > Repository: mesos > > > Description > ------- > > Define a variable earlier in the handler for clarity; add consts and > using directive where appropriate. > > > Diffs > ----- > > src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 > src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 > > Diff: https://reviews.apache.org/r/41603/diff/ > > > Testing > ------- > > make check on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
