> On Dec. 18, 2015, 10:37 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 150 > > <https://reviews.apache.org/r/41474/diff/1/?file=1167576#file1167576line150> > > > > The need to use `lambda::_1` here is a bit unfortunate.
I added a comment to clarify this. > On Dec. 18, 2015, 10:37 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 111 > > <https://reviews.apache.org/r/41474/diff/1/?file=1167576#file1167576line111> > > > > "with it" or "on it"? (I'm not actually sure.) I couldn't find a definitive answer on this, but it seems that "on" may be used a bit more commonly? On Dec. 18, 2015, 10:37 p.m., Greg Mann wrote: > > There have been non-deterministic bugs that have arisen from missing > > `defer`s -- i.e., whether a lack of `defer` causes problems can depend on > > the vagaries of the libprocess scheduler. e.g., > > https://reviews.apache.org/r/40610/diff/1#index_header -- would it be > > feasible/useful to walk through a simple example? Good idea, I've created a JIRA to track this improvement here: https://issues.apache.org/jira/browse/MESOS-4207 - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111287 ----------------------------------------------------------- On Dec. 19, 2015, 1:26 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41474/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2015, 1:26 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, > and Neil Conway. > > > Bugs: MESOS-3996 > https://issues.apache.org/jira/browse/MESOS-3996 > > > Repository: mesos > > > Description > ------- > > Added documentation for `defer` in libprocess README. > > > Diffs > ----- > > 3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5 > > Diff: https://reviews.apache.org/r/41474/diff/ > > > Testing > ------- > > Viewed the markdown in a branch on GitHub: > https://github.com/mesosphere/mesos/tree/defer_docs/3rdparty/libprocess > > > Thanks, > > Greg Mann > >
