> On Dec. 18, 2015, 7:37 a.m., Adam B wrote: > > src/tests/role_tests.cpp, line 120 > > <https://reviews.apache.org/r/41225/diff/7/?file=1170532#file1170532line120> > > > > s/by default/the default/ > > Neil Conway wrote: > ``` > $ ag "be filtered for 5 seconds (by default)" src/tests | wc -l > 18 > ``` > > i.e., this text occurs in many tests. I think we should use the same text > in each place. I'll open a separate review request to change them all.
Review request for this change here: https://reviews.apache.org/r/41567/ - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/#review111127 ----------------------------------------------------------- On Dec. 18, 2015, 8:01 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41225/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 8:01 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, and Yongqiao Wang. > > > Repository: mesos > > > Description > ------- > > Added test cases for implicit roles. > > > Diffs > ----- > > src/tests/role_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41225/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
