----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review110927 -----------------------------------------------------------
Looks great! Barring the nested labels discussion, I just had a couple of nits and it's otherwise shippable. src/tests/common/http_tests.cpp (lines 38 - 39) <https://reviews.apache.org/r/41188/#comment170930> Alphabetize, please src/tests/common/http_tests.cpp (lines 81 - 82) <https://reviews.apache.org/r/41188/#comment170932> Need to set DiscoveryInfo.visibility, since it's `required` src/tests/slave_tests.cpp (line 2169) <https://reviews.apache.org/r/41188/#comment170924> `Times(1)` is the default, unnecessary. Please delete. src/tests/slave_tests.cpp (line 2184) <https://reviews.apache.org/r/41188/#comment170931> May want to use a different example than "vip", if we're about to add `vips` as a first-class field. src/tests/slave_tests.cpp (lines 2190 - 2194) <https://reviews.apache.org/r/41188/#comment170925> s/`Port *port`/`Port* port`/ src/tests/slave_tests.cpp (line 2219) <https://reviews.apache.org/r/41188/#comment170928> Don't think you have to AWAIT on `response` here, since you AWAIT_EXPECT on it just below. src/tests/slave_tests.cpp (lines 2222 - 2224) <https://reviews.apache.org/r/41188/#comment170926> Doesn't this all fit on one 80-char line? Also, it looks like we have a AWAIT_EXPECT_RESPONSE_HEADER_EQ, but it doesn't really save any typing (1char?), and you don't need to AWAIT again. - Adam B On Dec. 16, 2015, 7:10 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41188/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 7:10 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-3962 > https://issues.apache.org/jira/browse/MESOS-3962 > > > Repository: mesos > > > Description > ------- > > Providing JSON bindings to so that mesos modules can expose DiscoveryInfo > protobuf messages to HTTP endpoints > > > Diffs > ----- > > src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239 > src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 > src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 > > Diff: https://reviews.apache.org/r/41188/diff/ > > > Testing > ------- > > make check. > Added Unit tests to verify setting of DiscoveryInfo in state.json in slave. > Also added Unit test to test that DiscoveryInfo gets exposed in master when > TaskInfo protobuf is converted to JSON objects. > > > Thanks, > > Avinash sridharan > >
