----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41250/#review110934 -----------------------------------------------------------
src/slave/slave.cpp (line 5194) <https://reviews.apache.org/r/41250/#comment170937> So we are going to only cover `SCALAR` resources? Is that necessary? - Klaus Ma On Dec. 14, 2015, 3:13 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41250/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 3:13 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, > and Klaus Ma. > > > Bugs: MESOS-4124 > https://issues.apache.org/jira/browse/MESOS-4124 > > > Repository: mesos > > > Description > ------- > > Enabled slave get ALLOCATION_SLACK metrics. > > > Diffs > ----- > > src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 > src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 > > Diff: https://reviews.apache.org/r/41250/diff/ > > > Testing > ------- > > $ curl "http://192.168.0.107:5051/metrics/snapshot"; 2>/dev/null| jq . | grep > alloc_slack > "slave/cpus_alloc_slack_revocable_percent": 0, > "slave/cpus_alloc_slack_revocable_total": 3, > "slave/cpus_alloc_slack_revocable_used": 0, > "slave/disk_alloc_slack_revocable_percent": 0, > "slave/disk_alloc_slack_revocable_total": 0, > "slave/disk_alloc_slack_revocable_used": 0, > "slave/mem_alloc_slack_revocable_percent": 0, > "slave/mem_alloc_slack_revocable_total": 1000, > "slave/mem_alloc_slack_revocable_used": 0, > > > Thanks, > > Guangya Liu > >
